[SDK] Expose getSetClaimConditionPhases #4913
Conversation
kien-ngo
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
size-limit report 📦
|
kien-ngo
added
the
DO NOT MERGE
Graphite App
| * @param options | ||
| * @utils | ||
| */ | ||
| export async function getSetClaimConditionPhases(options: { |
There was a problem hiding this comment.
this name is... very confusing.
I should be able to get a good idea of what this is for just by looking at the name.
Also i really dont think we should be exposing this this way. The inputs are kinda internal to us, you need to understand what tokenDecimals is for, what resetClaimEligibility does etc.
And once we expose it publicly, we can't change the API anymore.
Remind me again what's the use case you're trying to solve here? will help us figure out a good public API
There was a problem hiding this comment.
I can do better here. Let me update the code and ping you again. This is a non-urgent issue
joaquim-verges
left a comment
joaquim-verges
left a comment
There was a problem hiding this comment.
dont want to expose this in this form, needs to be simplified
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces the
getSetClaimConditionPhasesfunction to enhance the handling of claim conditions in the drops extension. It refactors thegetMulticallSetClaimConditionTransactionsfunction to utilize the new utility, improving code organization and reusability.Detailed summary
getSetClaimConditionPhasesfunction inget-set-claim-condition-phases.ts.getMulticallSetClaimConditionTransactionsto callgetSetClaimConditionPhases, removing redundant code.getMulticallSetClaimConditionTransactions.